[wp-trac] [WordPress Trac] #43749: Update zxcvbn to 4.4.2
WordPress Trac
noreply at wordpress.org
Thu Jun 14 14:14:52 UTC 2018
#43749: Update zxcvbn to 4.4.2
-------------------------------------+-----------------------------
Reporter: desrosj | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: External Libraries | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses: javascript
-------------------------------------+-----------------------------
Changes (by desrosj):
* keywords: has-patch => has-patch needs-refresh
Comment:
Hi @valchovski,
Thanks for the patch! Great to have you as a contributor.
The patch looks good to me, but it does require one change. The dictionary
text should be passed through a rot13 cipher to scramble the words. Some
of them are not PG, so they should be obscured. [ticket:31647:9] has some
coffee scripts that will help perform the rot13 change.
Although it may require a new ticket, it would be nice to have that
process included in the build process, if possible.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43749#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list