[wp-trac] [WordPress Trac] #35937: Visual improvements for the comment "pending status"

WordPress Trac noreply at wordpress.org
Thu Jun 14 12:31:55 UTC 2018


#35937: Visual improvements for the comment "pending status"
-----------------------------------------+--------------------------------
 Reporter:  afercia                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.0
Component:  Comments                     |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, accessibility
-----------------------------------------+--------------------------------

Comment (by xavortm):

 Uses :first-child:before so that it doesn't create a cell (even if
 absolute positioned).

 Tested on Safari: http://i.imgur.com/TO5Ppuq.png

 Chrome: http://i.imgur.com/CWhVzBg.png

 And firefox: http://i.imgur.com/ICmrb4T.png

 Mobile: http://i.imgur.com/jHes28Q.png

 (couldn't test on IE sorry)

 The markup between the two is different. The dashboard one uses <li> items
 while the "after editor" one uses table. I think this is understandable as
 the type of content is different, but I have the feeling that it's better
 to have them in the same markup, just add whatever information is needed
 in additional columns. Still wondering for list vs table. Probably table
 is best.

 Additional: I didn't add the label/icon in this patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35937#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list