[wp-trac] [WordPress Trac] #44356: Privacy settings page is listing non published pages

[WordPress Trac]

#44356: Privacy settings page is listing non published pages
-------------------------------------------------+-------------------------
 Reporter:  f2cmb                                |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Privacy                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion close has-patch          |     Focuses:
  reporter-feedback                              |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch 2nd-opinion => 2nd-opinion close has-patch reporter-
     feedback
 * milestone:  4.9.7 => Awaiting Review


Comment:

 The first part of the ticket (showing a notice in the admin when the
 policy is not publicly visible) is already being addressed in #44320.
 There are more details there, so let's focus the conversation on that
 ticket.

 I am not able to reproduce the second part of your ticket. On a fresh
 install, if the privacy policy page is in draft state, the `For more
 information, you can also read our privacy policy: URL` does not appear in
 the email. `get_privacy_policy_url()` will return an empty string if the
 privacy policy page is not published or not selected, which will cause the
 alternate email text to be used
 ([https://core.trac.wordpress.org/browser/tags/4.9.6/src/wp-
 includes/user.php#L3037 L3037]).

 Looking through core, most of the "get link" functions either return a
 string, `null`, or `false`. I think `false` would be ok to use here when
 the selected privacy policy page does not exist or is not published, but I
 don't think that this change is needed.

 @f2cmb if you are seeing the privacy policy link as empty in the
 confirmation email you specified, can you give me some steps to reproduce
 the issue?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44356#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform