[wp-trac] [WordPress Trac] #44353: Replace `site_url( 'wp-login.php' )` in `wp_send_user_request()`
WordPress Trac
noreply at wordpress.org
Tue Jun 12 22:31:23 UTC 2018
#44353: Replace `site_url( 'wp-login.php' )` in `wp_send_user_request()`
--------------------------------------+------------------------------
Reporter: 7studio | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses:
--------------------------------------+------------------------------
Comment (by birgire):
I'm not so sure about the suggestion:
{{{
site_url( 'wp-login.php', 'confirmaction' )
}}}
as the scheme input argument of {{{site_url()}}} and {{{get_site_url()}}}
is:
> {{{$scheme}}}
> (string) (Optional) Scheme to give the site URL context. Accepts 'http',
'https', 'login', 'login_post', 'admin', or 'relative'.
>
> Default value: null
https://developer.wordpress.org/reference/functions/get_site_url/
I would rather suggest:
{{{wp_login_url()}}}
instead of {{{site_url( 'wp-login.php' );}}}.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44353#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list