[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

WordPress Trac noreply at wordpress.org
Tue Jun 12 04:11:23 UTC 2018


#33735: Reduce Duplication and Improve Comment Notification Email Functions
----------------------------------------+-----------------------------
 Reporter:  dshanske                    |       Owner:  SergeyBiryukov
     Type:  enhancement                 |      Status:  reviewing
 Priority:  low                         |   Milestone:  5.0
Component:  Comments                    |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------

Comment (by dshanske):

 I can fix the $comment_id. But before I do, want to look at the other ones
 before I refresh

 * The older strings aren't consistent. Why is the moderation text
 different than the notification text? The information provided should be
 the same.
 * Any ideas for the name? I'm not tied to the name of the filter
 * No, it shouldn't handle the entire message. The purpose of the ticket is
 to split the duplicative parts of the two functions. The details of the
 comment, pingback, etc are duplicated. As the difference between the
 moderation and the notification message is the top and bottom portion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list