[wp-trac] [WordPress Trac] #38323: Reconsider $object_subtype handling in `register_meta()`

[WordPress Trac]

#38323: Reconsider $object_subtype handling in `register_meta()`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  kadamwhite
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * keywords:  has-patch needs-unit-tests needs-dev-note => has-patch needs-
     dev-note has-unit-tests
 * owner:  flixos90 => kadamwhite
 * status:  assigned => reviewing


Comment:

 [attachment:38323.11.diff] is an updated patch, with the following
 adjustments:

 * Move the filter in `get_object_subtype()` to fire at the very end, in
 order to always filter the returned value.
 * Simplify tests for subtype post meta in the REST API by using data
 providers.
 * Add tests for subtype term meta in the REST API.

 I think this is good to go in. Handing it over to you @kadamwhite for
 final review. We can also discuss at WCEU as necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38323#comment:72>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform