[wp-trac] [WordPress Trac] #42888: Add a "Show" button next to password fields on mobile

[WordPress Trac]

#42888: Add a "Show" button next to password fields on mobile
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  Iceable
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Login and Registration   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  accessibility,
  patch dev-feedback has-            |  javascript
  screenshots has-ux-feedback 2nd-   |
  opinion ux-feedback                |
-------------------------------------+-------------------------------------
Changes (by Iceable):

 * keywords:  good-first-bug has-patch dev-feedback has-screenshots has-ux-
     feedback =>
     good-first-bug has-patch dev-feedback has-screenshots has-ux-feedback
     2nd-opinion ux-feedback


Comment:

 Thank you very much @boemedia for taking the time to try it!

 I thought this patch would need a refresh as it is already 4 months old,
 though it still seems to apply and work correctly on my end. I just re-
 tested it on a Debian machine and on a MacOS one, both with a brand new
 VVV install.

 Steps taken:
 - Checked-out the latest commit from git://develop.git.wordpress.org/ on
 master (d3014a at the time of writing)
 - `$ grunt patch:42888`, then chose 42888-4.diff
 - `$ grunt build`

 Here is a screencap of wp-login.php in Chromium 66.0.3359.117 (Developer
 Build) on Debian 9.4.

 [[Image(https://i.imgur.com/NLLAzeq.gif)]]

 It also looks and works the same for me in Chrome 66.0.3359.181 (Official
 build) on MacOS.

 Not sure whether there is something wrong with this patch that doesn't
 show on my end, or if something went wrong during your test.

 Additional tests and/or 2nd opinion are most welcome.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42888#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform