[wp-trac] [WordPress Trac] #44052: Missing parameter type for `login_header()`
WordPress Trac
noreply at wordpress.org
Thu Jun 7 07:37:35 UTC 2018
#44052: Missing parameter type for `login_header()`
----------------------------------------+---------------------
Reporter: desrosj | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.9.7
Component: Login and Registration | Version:
Severity: normal | Resolution:
Keywords: good-first-bug needs-patch | Focuses: docs
----------------------------------------+---------------------
Comment (by flixos90):
@sebastien at thivinfo.com
Thanks for the updated patch! A few remarks:
* The documentation for the parameter should continue to only state
`WP_Error` as type. Also its description should be changed to use
"Optional. The error to pass. Default is a new empty error."
* Please remove line 41, as it introduces a parse error.
* Please avoid unnecessary blank lines like in lines 46 and 47.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44052#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list