[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

[WordPress Trac]

#33735: Reduce Duplication and Improve Comment Notification Email Functions
----------------------------------------+-----------------------------
 Reporter:  dshanske                    |       Owner:  SergeyBiryukov
     Type:  enhancement                 |      Status:  reviewing
 Priority:  low                         |   Milestone:  5.0
Component:  Comments                    |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------

Comment (by birgire):

 Replying to [comment:26 dshanske]:
 > I refreshed this. I still, two years later, can't figure out how to unit
 test this. Always been a bit of a hard issue for me. I've manually tested
 this patch. But I can't find unit tests for the original wp_notify
 functions to based it on.
 >
 > I'd like to get this in after all this time.

 Great. The patch in {{{pluggable.php}}} does not apply cleanly with trunk,
 for me though:

 {{{
 patching file src/wp-includes/comment-template.php
 Hunk #1 succeeded at 2536 (offset 71 lines).
 patching file src/wp-includes/pluggable.php
 Hunk #1 FAILED at 1452.
 Hunk #2 FAILED at 1618.
 Hunk #3 FAILED at 1670.
 3 out of 3 hunks FAILED -- saving rejects to file src/wp-
 includes/pluggable.php.rej

 }}}

 ps: I could try to look at the unit tests.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform