[wp-trac] [WordPress Trac] #44124: Adding is_countable() check to custom-header.php

WordPress Trac noreply at wordpress.org
Fri Jun 1 18:47:16 UTC 2018


#44124: Adding is_countable() check to custom-header.php
--------------------------+----------------------
 Reporter:  ianbelanger   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  General       |     Version:
 Severity:  normal        |  Resolution:  wontfix
 Keywords:                |     Focuses:
--------------------------+----------------------
Changes (by desrosj):

 * keywords:  has-patch needs-testing close =>
 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  4.9.8 =>


Comment:

 Looked this over. Agree that this instance of `count()` should not be
 updated.

 Breaking it down, `$headers` ''could'' be of a type that is not countable,
 but only if the `$_wp_default_headers` global is overridden. In this
 scenario, an error should be thrown to indicate improper usage of
 `$_wp_default_headers`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44124#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list