[wp-trac] [WordPress Trac] #44117: Privacy: Don't always link to the menu customizer
WordPress Trac
noreply at wordpress.org
Fri Jun 1 18:38:50 UTC 2018
#44117: Privacy: Don't always link to the menu customizer
-----------------------------------+-----------------------------
Reporter: dlh | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.9.7
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch gdpr commit | Focuses: administration
-----------------------------------+-----------------------------
Changes (by desrosj):
* keywords: has-patch gdpr => has-patch gdpr commit
* focuses: => administration
* milestone: 4.9.8 => 4.9.7
Comment:
@dlh this looks good to me and tests well.
Only nit pick I have is that I ''believe'' the rule with multi-line
conditionals is one per line leaving the first conditional on the same
line as the `if(`. I couldn't find the rule stated anywhere in WPCS
ruleset, or in the handbook, though.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44117#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list