[wp-trac] [WordPress Trac] #44500: Mark data requests failed when an expired link is clicked

[WordPress Trac]

#44500: Mark data requests failed when an expired link is clicked
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |  administration
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-testing needs-unit-tests needs-refresh => has-
     patch needs-testing has-unit-tests
 * focuses:   => administration
 * milestone:  Awaiting Review => Future Release


Comment:

 @garrett-eclipse in `wp_validate_user_request_key()`, there is a check
 that returns an error if the request is not pending or failed. I found a
 bug with that, though (see #44685). Once that is resolved,
 `wp_mark_user_request_failed()` will not be called by core in those
 scenarios.

 That said, it won't handle situations where
 `wp_mark_user_request_failed()` is called directly by plugins. For those,
 I aded an additional `WP_Error` in `wp_mark_user_request_failed()` for
 when a request has already been completed. I did not add an error for
 attempting to set a ''confirmed'' request as failed. I could see a
 scenario where a plugin might want to mark a confirmed request as failed,
 maybe if the plugin generates and sends its own export file and it does
 not succeed.

 [attachment:"44500.2.diff"] also has unit tests for
 `wp_mark_user_request_failed()` and the
 `_wp_personal_data_cleanup_requests()` function, the only place that calls
 the first function in core.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44500#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform