[wp-trac] [WordPress Trac] #44500: Mark data requests failed when an expired link is clicked

[WordPress Trac]

#44500: Mark data requests failed when an expired link is clicked
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests needs-refresh                            |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-testing needs-unit-tests => has-patch needs-
     testing needs-unit-tests needs-refresh


Comment:

 Reviewing the patch @desrosj it doesn't appear there's any consideration
 for if the request is already completed and the user is visiting the link
 for a second time. I would suggest updating wp_mark_user_request_failed to
 check the state of the request and only fail it if it's in the Confirmed
 state or maybe Pending & Confirmed. If instead you suppress the update if
 in Completed state then we should also suppress if in archived state which
 is possible if #44222 moves forward.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44500#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform