[wp-trac] [WordPress Trac] #44590: Remove "// WPCS:" comments
WordPress Trac
noreply at wordpress.org
Tue Jul 24 22:13:10 UTC 2018
#44590: Remove "// WPCS:" comments
-------------------------------------------------+-------------------------
Reporter: pento | Owner: pento
Type: defect (bug) | Status: closed
Priority: low | Milestone: 4.9.8
Component: Privacy | Version: 4.9.6
Severity: trivial | Resolution: fixed
Keywords: good-first-bug has-patch commit | Focuses:
fixed-major |
-------------------------------------------------+-------------------------
Comment (by jrf):
I suspect these crept in when someone tested the patch against the WPCS
`WordPress` ruleset before submitting it.
For core patches, the `phpcs.xml.dist` ruleset in the WP root directory
should be used instead. This custom ruleset is based on the WPCS
`WordPress-Core` ruleset, which, for on the fly patch CS testing, could in
most cases be used interchangably.
The `WordPress-Core` ruleset does not contain the sniffs for which these
whitelist comments are applicable.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44590#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list