[wp-trac] [WordPress Trac] #44541: Text length should be localizable

WordPress Trac noreply at wordpress.org
Tue Jul 24 14:13:24 UTC 2018


#44541: Text length should be localizable
--------------------------------------+---------------------
 Reporter:  miyauchi                  |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  5.0
Component:  I18N                      |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by birgire):

 The reason why the earlier tests didn't pass for me, was that I missed the
 updated {{{ja_JA.mo}}} file :)

 I tested with:

 https://github.com/miya0001/wpdev/blob/2415c793e52740b4e68b954703797a9d4f762069/tests/phpunit/data/languages/ja_JP.mo

 and the tests now pass as expected.

 The patch in [attachment:"44541.5.diff"]
 - Makes sure the locale is also restored before the assertions in
 {{{Tests_Formatting_WPTrimWords}}} methods.
 - Makes adjustments according to WPCS.
 - Adds a docblock for the private {{{$long_text}}} property, in both test
 files.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44541#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list