[wp-trac] [WordPress Trac] #41545: Allow cmd/ctrl-enter to submit comment forms
WordPress Trac
noreply at wordpress.org
Thu Jul 19 21:29:35 UTC 2018
#41545: Allow cmd/ctrl-enter to submit comment forms
-------------------------------------------------+-------------------------
Reporter: helen | Owner:
| adamsilverstein
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.9.9
Component: Comments | Version:
Severity: minor | Resolution:
Keywords: good-first-bug needs-testing has- | Focuses: javascript
patch needs-refresh |
-------------------------------------------------+-------------------------
Changes (by adamsilverstein):
* milestone: 4.9.8 => 4.9.9
Comment:
I took a look at this yesterday and I think it needs a little more work to
be ready:
* Let's attach the event listener in JavaScript instead of in the HTML of
the element itself. This makes it easier to tell where the event is
getting called from and is the common pattern we use across most of core.
* Switch to the `keyup` event instead of `keydown` which I think is better
from a usability perspective?
* Can we find/submit the original form instead of the current approach of
creating a form?
Punting to 4.9.9 while we finish up these details.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41545#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list