[wp-trac] [WordPress Trac] #44533: wp_is_stream wrappers need preg delimiter when quoting

WordPress Trac noreply at wordpress.org
Wed Jul 18 03:22:51 UTC 2018


#44533: wp_is_stream wrappers need preg delimiter when quoting
------------------------------------------+----------------------
 Reporter:  JPry                          |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  closed
 Priority:  normal                        |   Milestone:  5.0
Component:  Filesystem API                |     Version:
 Severity:  normal                        |  Resolution:  wontfix
 Keywords:  needs-unit-tests needs-patch  |     Focuses:
------------------------------------------+----------------------
Changes (by pento):

 * keywords:  has-patch has-unit-tests => needs-unit-tests needs-patch
 * version:  trunk =>
 * milestone:   => 5.0


Comment:

 The tests are failing on PHP 5.2:

 {{{
 1) Tests_Functions::test_wp_is_stream with data set #0
 ('https://example.com', true)
 Failed asserting that false matches expected true.
 /home/travis/build/WordPress/wordpress-
 develop/tests/phpunit/tests/functions.php:1464
 }}}

 https://travis-ci.org/WordPress/wordpress-develop/jobs/405160164

 It appears that Travis' PHP 5.2 build doesn't have `openssl` built in, so
 `https` is not a stream that will actually work. 🙂

 I would suggest testing for `extension_loaded( 'openssl' )`, and use that
 to decide whether a `http` or `https` URL should be used.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44533#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list