[wp-trac] [WordPress Trac] #44533: wp_is_stream wrappers need preg delimiter when quoting

WordPress Trac noreply at wordpress.org
Tue Jul 17 05:02:26 UTC 2018


#44533: wp_is_stream wrappers need preg delimiter when quoting
--------------------------------------+----------------------
 Reporter:  JPry                      |       Owner:  (none)
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:
Component:  Filesystem API            |     Version:  trunk
 Severity:  normal                    |  Resolution:  wontfix
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+----------------------
Changes (by pento):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  4.9.8 =>


Comment:

 Thank you for the report and patch, @JPry!

 I was thinking about this, but we don't really need to make the change,
 for two reasons:

 - `!` is a special character that `preg_quote()` already escapes.
 - `!` isn't a character that PHP allows in stream names, so if it shows up
 in `$wrappers`, things have gone horribly wrong.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44533#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list