[wp-trac] [WordPress Trac] #44025: Privacy: Pagination screen options for the requests list tables
WordPress Trac
noreply at wordpress.org
Tue Jul 10 22:00:33 UTC 2018
#44025: Privacy: Pagination screen options for the requests list tables
-------------------------------------------------+-------------------------
Reporter: birgire | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 4.9.8
Component: Privacy | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses:
testing | administration
-------------------------------------------------+-------------------------
Comment (by birgire):
Thanks @pbiron and @desrosj
doh, it looks like the patch [attachment:"44025.diff"] I uploaded wasn't
the patch I intended, sorry about that :) I remember testing the
pagination successfully and I can see that in the ticket's description I
mentioned using {{{$this->get_items_per_page()}}} but my uploaded patch
included {{{$this->get_pagination_arg()}}}, most likely from some earlier
testing that also included a filter typo :)
ps: I also remember wanting to use the {{{'paged'}}} query parameter
instead of calculating {{{'offset'}}}, in
{{{WP_Privacy_Requests_Table::prepare_items()}}}, but that's unrelated :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44025#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list