[wp-trac] [WordPress Trac] #44025: Privacy: Pagination screen options for the requests list tables

[WordPress Trac]

#44025: Privacy: Pagination screen options for the requests list tables
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.8
Component:  Privacy                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  testing                                        |  administration
-------------------------------------------------+-------------------------
Changes (by pbiron):

 * keywords:  has-screenshots, has-patch, needs-testing => has-screenshots
     has-patch needs-testing


Comment:

 [[https://core.trac.wordpress.org/attachment/ticket/44025/44025.1.diff|44025.1.diff]]
 fixes a couple of issues with
 [[https://core.trac.wordpress.org/attachment/ticket/44025/44025.diff|44025.diff]]:

 1. typo in action in `/wp-admin/includes/admin-filters.php`
     * `load-tools_page_removal_personal_data` => `load-
 tools_page_remove_personal_data`
 2. incorrect method call to get `$posts_per_page` in
 `WP_Privacy_Requests_Table::prepare_items()`
     * `$this->get_pagination_arg(...);` =>
 `$this->get_items_per_page(...)`

 I also couldn't find anywhere else in core that sets a label for the
 `per_page` screen option (a few plugins I use set it, but nowhere in
 core), so I removed that.

 I'd appreciate someone testing this patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44025#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform