[wp-trac] [WordPress Trac] #44192: Title of Privacy Policy Page not used on login page
WordPress Trac
noreply at wordpress.org
Tue Jul 10 11:25:06 UTC 2018
#44192: Title of Privacy Policy Page not used on login page
-------------------------------------------------+-------------------------
Reporter: Ov3rfly | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.9.8
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests has- | Focuses:
screenshots |
-------------------------------------------------+-------------------------
Comment (by birgire):
[attachment:"44192.3.diff"] has just few suggestions, based on
[attachment:"44192.2.diff"] :
- Escapes the privacy page title within the output of
{{{get_the_privacy_policy_link()}}}.
- Adds the annotation {{{@ticket 44192}}} for the new test method.
- Adjusts to the new test method name and description.
- As {{{assertEmpty()}}} results true for more than an empty string, e.g.
{{{null}}}, {{{false}}}, I replaced it with {{{assertSame( '', ... )}}},
similar as in the existing
{{{test_get_the_privacy_policy_link_should_return_empty_string_when_privacy_page_not_set()}}}
method.
- Combines assertions in
{{{test_get_the_privacy_policy_link_should_return_valid_link_when_privacy_page_set()}}}.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44192#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list