[wp-trac] [WordPress Trac] #44133: Should the Data Export indicate when we have no information on the user
WordPress Trac
noreply at wordpress.org
Mon Jul 9 20:10:11 UTC 2018
#44133: Should the Data Export indicate when we have no information on the user
-------------------------------------------------+-------------------------
Reporter: garrett-eclipse | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 4.9.8
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses:
testing | administration
-------------------------------------------------+-------------------------
Comment (by birgire):
Good improvement on the wording.
Few thoughts related to the ticket:
- Within the {{{_wp_privacy_send_erasure_fulfillment_notification()}}}
function, we have a single {{{user_confirmed_action_email_content}}}
filter
([https://github.com/WordPress/WordPress/blob/057b221af7edaff049977d48850df3cac4a101be
/wp-includes/user.php#L3192 src]) for both empty and non-empty privacy
policy url. Should we use the same structure here for the
{{{wp_privacy_personal_data_email_content}}} filter, in the case of
available export data and no-data, for consistency?
- I think we could skip the {{{$has_export_data}}} filter arguments, if
two filters are used. It's needed though in the one filter approach.
- We should consider adding a unit test, e.g.
{{{Tests_Privacy_WpPrivacySendPersonalDataExportEmail::test_function_should_send_email_to_requester_without_export_link_when_no_export_data_found()}}}.
I can look into that.
- If the export data, defined by plugins, is e.g. missing
{{{'group_id'}}}, {{{'group_label'}}}, {{{'item_id'}}} or {{{'items'}}},
then it seems that we can get PHP notices. Also it seems possible for
empty items to get registered into the {{{_export_data_grouped}}} post
meta, that is used to generate export files. I'm considering creating a
new ticket for this.
- Just thinking out aloud, regarding the use of email placeholders in the
email content: I guess it could be useful for users that have more than
one email address, where all their email is collected by a single one.
Those users might need to send a privacy request for each email address.
(e.g. they might have used different email addresses when commenting on a
site over the years).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44133#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list