[wp-trac] [WordPress Trac] #44521: Add documentation to the PHPUnit factory objects

WordPress Trac noreply at wordpress.org
Thu Jul 5 13:34:38 UTC 2018


#44521: Add documentation to the PHPUnit factory objects
-------------------------+------------------------------
 Reporter:  andizer      |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  docs
-------------------------+------------------------------

Comment (by JPry):

 @andizer

 One thing I noticed when doing a quick skim of your patch: The docblock
 for {{{WP_UnitTest_Factory_Callback_After_Create::__construct()}}} has
 {{{string}}} as the parameter type. This should actually be
 {{{callable}}}. While this type hint is only valid in PHP 5.4+, using it
 in the docblock won't have any issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44521#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list