[wp-trac] [WordPress Trac] #44370: wp_privacy_delete_old_export_files runs too much on some setups

WordPress Trac noreply at wordpress.org
Tue Jul 3 14:09:43 UTC 2018


#44370: wp_privacy_delete_old_export_files runs too much on some setups
--------------------------+------------------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Privacy       |     Version:  4.9.6
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Changes (by desrosj):

 * keywords:   => needs-patch


Comment:

 I think this is a good idea. I like the option of single cleanup events
 paired with a daily event to check for missed files the best.

 My one concern is that once a site has many completed requests, the daily
 cron checking for missed files will not be performant (I don't think it
 will be uncommon for users to keep completed requests for the record). A
 date query could help with that, only querying requests updated within the
 last X days. For this value, we can default to 3 days, but we should make
 sure to use the `wp_privacy_export_expiration` filter that is also used in
 `wp_privacy_delete_old_export_files()` in case a site changes the
 expiration time.

 Multisite support is on the
 [https://make.wordpress.org/core/roadmap/privacy/ Privacy Component Road
 Map]. @boonebgorges if you have any more multisite feedback, please do
 collect it and drop it in #core-privacy.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44370#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list