[wp-trac] [WordPress Trac] #43025: wp_list_filter should filter all iterable objects
WordPress Trac
noreply at wordpress.org
Wed Jan 31 08:44:50 UTC 2018
#43025: wp_list_filter should filter all iterable objects
--------------------------------------+------------------------------
Reporter: jarednova | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 4.9.1
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------------
Changes (by swissspidy):
* keywords: has-patch needs-unit-tests => has-patch has-unit-tests
Comment:
@flixos90 Since you worked on `WP_List_Util`, would you mind having a
look?
I think we can add such a check directly to the class instead of the
helper function.
Also, I'd use `instanceof` instead of `is_a()`. We rarely use the latter
in core and it's better to be consistent.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43025#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list