[wp-trac] [WordPress Trac] #42586: Code Editor: Inconsistent results between finding in CodeMirror vs browser

[WordPress Trac]

#42586: Code Editor: Inconsistent results between finding in CodeMirror vs browser
------------------------------+--------------------------------------------
 Reporter:  wpress2010        |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:  4.9.3
Component:  General           |     Version:  4.9
 Severity:  major             |  Resolution:
 Keywords:  has-patch needs-  |     Focuses:  accessibility, administration
  testing                     |
------------------------------+--------------------------------------------

Comment (by Clorith):

 The patch looks fine, some considerations from testing it out though:

 We should grab some styles for the active search result, currently all
 search results, and the active one, get the same yellow color, making it
 impossible to distinguish which one you are currently observing as the
 active result, this is especially bothersome as you can't "find backwards"
 if you go too far.

 Another is that the current implementation only works if the CodeMirror
 window has focus, this is not the default state, so if I pick a file to
 edit and then instantly hit ctrl/cmd+f to find what i need, I'll still get
 the browser search. It might be worth considering either auto-focusing the
 editor, or hijacking the search command on the editor pages only to
 provide a better user experience.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42586#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform