[wp-trac] [WordPress Trac] #42265: get_filesystem_method() isn't unique enough

[WordPress Trac]

#42265: get_filesystem_method() isn't unique enough
----------------------------+------------------------------------------
 Reporter:  bikecrazyy      |       Owner:  dd32
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  5.0
Component:  Filesystem API  |     Version:  2.5
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:  administration, performance
----------------------------+------------------------------------------

Comment (by rogerlos):

 As an example of a plugin combination which can trigger this in the
 existing codebase:

 "'''All in One Event Calendar by Timely'''" hits this function (via
 `WP_Filesystem` at least once every time the plugin is called, to see if
 their cache directory is available. (Which seems like something which
 should only be done on install or periodically, but not my plugin...)

 "'''PageBuilder by SiteOrigin'''" uses a lot of ajax calls when working
 with its tool in the editor, and can generate several calls in a very
 short period of time. If two calls are made within the same tick of the
 system clock, as it were, "All in One" will cause a PHP warning via this
 bug.

 I haven't checked, but I can imagine the new editor for 5.0, being ajax
 based, may cause similar issues with plugins like AIOEC. Look forward to
 seeing this fix.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42265#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform