[wp-trac] [WordPress Trac] #43150: Update Emoji build step to follow WP Coding Standards.

WordPress Trac noreply at wordpress.org
Wed Jan 24 22:45:25 UTC 2018


#43150: Update Emoji build step to follow WP Coding Standards.
------------------------------+-------------------------------
 Reporter:  peterwilsoncc     |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  coding-standards
------------------------------+-------------------------------

Comment (by netweb):

 [attachment:43150.2.diff] adds the `phpcs:disable` to avoid any PHPCS
 warnings for the ''built'' lines to `src/wp-includes/formatting.php` and
 updates the format to be:

 {{{#!php
 <?php
 function _wp_emoji_list( $type = 'entities' ) {
         // Do not remove the START/END comments - they're used to find
 where to insert the arrays.

         // phpcs:disable
 WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine -- don't
 format the array across 4000 lines
         // phpcs:disable
 WordPress.Arrays.CommaAfterArrayItem.NoSpaceAfterComma

         // START: emoji arrays
         $entities = array(
 '&#x1f469;&#x200d;&#x2764;&#xfe0f;&#x200d;&#x1f48b;&#x200d;&#x1f469;','&#x1f469;&#x200d;&#x2764;&#xfe0f;&#x200d;&#x1f48b;&#x200d;&#x1f468;',...
         );
         $partials = array(
 '&#x1f004;','&#x1f0cf;','&#x1f170;','&#x1f171;','&#x1f17e;','&#x1f17f;','&#x1f18e;','&#x1f191;','&#x1f192;','&#x1f193;','&#x1f194;','&#x1f195;',...
         );
         // END: emoji arrays

         // phpcs:enable

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43150#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list