[wp-trac] [WordPress Trac] #43055: Reorganize Core JS / introduce build step

WordPress Trac noreply at wordpress.org
Wed Jan 24 06:15:35 UTC 2018


#43055: Reorganize Core JS / introduce build step
------------------------------+-------------------------
 Reporter:  omarreiss         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  javascript
------------------------------+-------------------------

Comment (by jaswrks):

 @omarreiss I just took your awesome changes for a test drive, running
 `grunt build` from your mirror. I then went through some of the file
 differences that you listed above to see if I could help.

 - `jquery.js` needs to have `jQuery.noConflict();` appended to it.

 - It looks like `jquery-hoverintent` has a slightly different build
 variation at NPM (perhaps a mistake on the part of the maintainer). I
 [https://github.com/briancherne/jquery-hoverIntent/issues/67 opened an
 issue here] in that project's repo.

 - The only difference I'm seeing in the `jquery.color.min.js` file is in
 the variables used by the minifier; e.g., `function m(a,b,c)` vs.
 `function h(e,t,n)`. They appear to be identical otherwise.

 - `underscore.min.js` in the NPM package has a sourcemap reference at the
 bottom.

 - `zxcvbn.min.js` in the NPM package has a sourcemap reference at the
 bottom, and for whatever reason is missing the copyright comment at the
 top.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43055#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list