[wp-trac] [WordPress Trac] #39859: wp.media.view.Modal jumps when you open it
WordPress Trac
noreply at wordpress.org
Wed Jan 24 01:42:40 UTC 2018
#39859: wp.media.view.Modal jumps when you open it
------------------------------+----------------------------------------
Reporter: andreiglingeanu | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.9.3
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: accessibility, javascript
------------------------------+----------------------------------------
Changes (by adamsilverstein):
* keywords: has-patch needs-refresh => has-patch commit
Comment:
@afercia aha, i missed the point! I thought the main issue was the
scrolling - I see now that is just a side effect of the focus problem.
On the second point '''you are exactly right''', my recollection was
incorrect... Checking the docs http://backbonejs.org/#View-dollar it
explicitly states that `{view}.$` can be used as a scoped selector: ` It's
equivalent to running: view.$el.find(selector)`. Apologies for misspeaking
earlier about that.
All that said, I think [attachment:39859.3.diff] is good to go!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39859#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list