[wp-trac] [WordPress Trac] #42850: jshint.js uses non-free license

[WordPress Trac]

#42850: jshint.js uses non-free license
-----------------------------------+-------------------------
 Reporter:  csmall2                |       Owner:  jorbin
     Type:  defect (bug)           |      Status:  reopened
 Priority:  high                   |   Milestone:  4.9.3
Component:  General                |     Version:  4.9
 Severity:  major                  |  Resolution:
 Keywords:  has-patch fixed-major  |     Focuses:  javascript
-----------------------------------+-------------------------

Comment (by jorbin):

 Replying to [comment:10 netweb]:
 > Patch [attachment:42850.2.diff] contains a spelling fix
 ''s/liscensed/licensed''
 >
 > > ''"Unlike a typical code linter, this syntax validator does '''not'''
 care about coding styles and formatting."''
 > >
 > > ''"If there is a syntax error, the sign ⚠️ will be shown in the left-
 side gutter. Placing the mouse cursor over that sign will reveal the
 complete error description."''
 >
 > Should this implementation here or can the Esprima "warnings" be changed
 to "errors"
 >
 > Or should that be looked at for 5.0 and go with this as is for 4.9.3?

 I'm absolutely open to improvements for 5.0.  In my eyes, getting rid of
 JSHint for 4.9.3 is a case where perfect is the enemy of complete.
 Esprima isn't going to solve things forever, but license issue with JSHint
 issues are resolved in a way that will allow it to come back so that style
 checks can come back.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42850#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform