[wp-trac] [WordPress Trac] #42850: jshint.js uses non-free license

[WordPress Trac]

#42850: jshint.js uses non-free license
--------------------------+-------------------------
 Reporter:  csmall2       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  4.9.3
Component:  General       |     Version:  4.9
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by netweb):

 Patch [attachment:42850.2.diff] contains a spelling fix
 ''s/liscensed/licensed''

 Testing wise, does what it says on the box, replaces JSHint with Esprima
 +1

 With that said, I'm not familiar with Esprima and I've not been able to
 trigger an "error" condition, only "warnings".

 Looking at this page http://esprima.org/demo/validate.html it states:

 > ''"Unlike a typical code linter, this syntax validator does '''not'''
 care about coding styles and formatting."''
 >
 > ''"If there is a syntax error, the sign ⚠️ will be shown in the left-
 side gutter. Placing the mouse cursor over that sign will reveal the
 complete error description."''

 Should this implementation here or can the Esprima "warnings" be changed
 to "errors"

 Or should that be looked at for 5.0 and go with this as is for 4.9.3?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42850#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform