[wp-trac] [WordPress Trac] #42991: Customizer: Search Menu item not working on Custom Link
WordPress Trac
noreply at wordpress.org
Mon Jan 22 05:18:51 UTC 2018
#42991: Customizer: Search Menu item not working on Custom Link
---------------------------------------+------------------------
Reporter: monikarao | Owner: melchoyce
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.9.3
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch needs-testing | Focuses: ui
---------------------------------------+------------------------
Changes (by westonruter):
* keywords: has-patch => needs-patch needs-testing
Comment:
On second thought, this perhaps should use `mb_stripos()` if possible
since the translation string will have multi-byte characters in it. For
example compare:
{{{
wp> stripos( 'PAPÁ', 'á' )
=> bool(false)
wp> mb_stripos( 'PAPÁ', 'á' )
=> int(3)
}}}
I believe you'll have to check if the `mb_stripos()` function exists since
the multibyte string functions may not be present, and in such case you'll
need to use `stripos()`. At least, `_wp_json_convert_string()` checks for
the existence of an `mb_*` function prior to using it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42991#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list