[wp-trac] [WordPress Trac] #42850: jshint.js uses non-free license

[WordPress Trac]

#42850: jshint.js uses non-free license
--------------------------+-------------------------
 Reporter:  csmall2       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  4.9.3
Component:  General       |     Version:  4.9
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------
Changes (by jorbin):

 * keywords:  coding-standards => has-patch
 * component:  Build/Test Tools => General


Comment:

 JSHINT is fairly ingrained into CodeMirror for JavaScript Linting. At
 first, I looked into just removing it and that means that JavaScript
 wouldn't be error checked at all in the editor.  As that is a less than
 ideal solution, I've gone and included [esprima](http://esprima.org/)
 which is available under a BSD license and written a small wrapper in
 order to convert the errors it generates into the style that CodeMirror is
 looking for.

 I haven't removed any of the JSHINT config stuff in case someone wanted to
 load there own copy, but this won't be something that can be distributed
 via a plugin.

 For 4.9.3, since we can't include new files, I'll combine fakejshint.js
 and esprima.js into the jshint.js file.

 I want to make sure this is included in the beta for 4.9.3, so I'm going
 to commit it tomorrow barring objection or alternatives.

 The switching of our dev tools use of jshint can continue to happen in
 #31823 as that isn't bundled with WordPress and this should be purely
 about the distribution of jshint with WordPress.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42850#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform