[wp-trac] [WordPress Trac] #38332: "Cheating" message insults; needs changing

[WordPress Trac]

#38332: "Cheating" message insults; needs changing
--------------------------+-----------------------------
 Reporter:  ElectricFeet  |       Owner:
     Type:  enhancement   |      Status:  reopened
 Priority:  normal        |   Milestone:  4.9.3
Component:  General       |     Version:  2.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  administration
--------------------------+-----------------------------
Changes (by dmsnell):

 * keywords:  needs-patch => has-patch


Comment:

 At WordCamp Albuquerque 2018 Contributor Day we found an existing string
 that was translated that seemed to convey the function of the "cheatin"
 message but without the hostility. We opted to reuse an existing string so
 that this patch could merge and not cause a loss of translation or
 increase the burden on translators.

 Of note, something that I would appreciate some review on, we modified the
 key on the JavaScript global variable `_wpCustomizeControlsL10n`. We
 believe that we covered all of our internal uses of this key but it's not
 clear to us whether plugins or themes may also depend on the existing
 `cheatin` property.

 Thanks for the review, we hope this resolves the issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38332#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform