[wp-trac] [WordPress Trac] #42867: HTML Widget: toggleClass() should be passed true/false as second param

[WordPress Trac]

#42867: HTML Widget: toggleClass() should be passed true/false as second param
-------------------------------------+--------------------------
 Reporter:  iCaleb                   |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.9.2
Component:  Widgets                  |     Version:  4.9
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"42457"]:
 {{{
 #!CommitTicketReference repository="" revision="42457"
 Widgets: When checking for errors in Custom HTML widget, pass correct
 value to `toggleClass()` for Save button.

 `toggleClass()` expects a boolean as a second argument, not an integer.

 Props iCaleb.
 Fixes #42867.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42867#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform