[wp-trac] [WordPress Trac] #37923: Introduce shared wp_blogmeta database table for multisite installation
WordPress Trac
noreply at wordpress.org
Sun Jan 14 19:14:04 UTC 2018
#37923: Introduce shared wp_blogmeta database table for multisite installation
-------------------------------------------------+-------------------------
Reporter: johnjamesjacoby | Owner: flixos90
Type: feature request | Status: reviewing
Priority: normal | Milestone: 5.0
Component: Networks and Sites | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests needs- | Focuses: multisite
testing ms-roadmap |
-------------------------------------------------+-------------------------
Comment (by spacedmonkey):
In [https://core.trac.wordpress.org/attachment/ticket/37923/37923.16.diff
37923.16.diff] these are the key changes.
- Removed checks to see if site meta exists. When a new test suite is run,
then site meta will be installed and always will be there.
- Added `test_is_site_meta_supported_filtered` test.
- Added a doing it wrong message is you call *_site_meta and the table
isn't installed.
- Added `$update_meta_cache` param to `update_site_cache`
@jeremyfelt I have reviewed the tested and compared them to existing unit
tests for other object types. I think these tests hold up pretty well. We
are not testing meta queries as not supporting this right now. Otherwise
most of these are very simple wrappers for the meta functions. Any testing
on caching for meta, should be done upsteam in the meta functions tests.
As for `@todo use clean_blog_cache here` this is related to when site meta
query (#40229) + granular caching for site query (#42252) go into core.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37923#comment:78>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list