[wp-trac] [WordPress Trac] #42643: FLV video format not playing
WordPress Trac
noreply at wordpress.org
Fri Jan 12 21:29:26 UTC 2018
#42643: FLV video format not playing
--------------------------+-------------------------
Reporter: studiosx | Owner: Clorith
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.9.2
Component: Media | Version: 4.9
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
--------------------------+-------------------------
Comment (by adamsilverstein):
@Clorith patch looks good, nice work! Took me a bit to figure out I had to
be on the front end to see the error.
[attachment:42643.2.patch] could use few small changes: tabs please
instead of spaces, and more whitespace in `node.src.substring`. finally,
JSDocs for the parameters and return would also be great.
I tested with the flv you provided, here are some screenshots for a visual
record of this change:
Before the patch:
[[Image(https://cl.ly/1n2Z3N3a3u1x/Image%202018-01-12%20at%204.19.57%20PM.png)]]
After the patch I see the custom error and its linked:
[[Image(https://cl.ly/393O0j1j302l/Image%202018-01-12%20at%204.18.35%20PM.png)]]
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42643#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list