[wp-trac] [WordPress Trac] #42480: Consistent suppression of `getimagesize()` errors

[WordPress Trac]

#42480: Consistent suppression of `getimagesize()` errors
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:  joemcgill
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.9.2
Component:  Media                                |     Version:  2.5
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by jeremyfelt):

 @joemcgill Close, but there was one more `getimagesize()` that needed to
 be silenced for our errors to go away. That's updated in
 [attachment:42480.3.diff].

 There are a handful of other non-suppressed `getimagesize()` calls left in
 core, though they're only ever called with one parameter. It seems to be
 only when called with two that it's showing the problem we're seeing
 (confirmed in the PHP bug report).

 I'm +1 on [attachment:42480.3.diff], though it sounds like @blobfolio's
 patch on #35725 could be interesting for the future.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42480#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform