[wp-trac] [WordPress Trac] #37923: Introduce shared wp_blogmeta database table for multisite installation

[WordPress Trac]

#37923: Introduce shared wp_blogmeta database table for multisite installation
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:  flixos90
     Type:  feature request                      |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0
Component:  Networks and Sites                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  multisite
  testing ms-roadmap                             |
-------------------------------------------------+-------------------------

Comment (by jeremyfelt):

 Things are looking good in [attachment:37923.15.diff]. Nice stuff,
 @flixos90 and @spacedmonkey.

 Some notes during a read through:
 * We'll need a dev note explaining the move of `formatting.php` and
 `meta.php` and what that does or does not do to performance during
 `SHORTINIT`.
 * I'm not sure if I understand the `is_site_meta_supported()` test. We've
 set it up to always pass. Can we rely on the table always being there
 during the tests? Ideally, this should probably only test that `true` is
 returned and then test `false` as a filtered condition.
 * Why skip tests when `is_site_meta_supported()` returns `false`? That the
 table does not exist could indicate a failure overall.
 * There was some conversation earlier about returning `false` vs a
 `WP_Error` object. It seems useful to return `WP_Error` specifically in
 the case where `is_site_meta_supported()` returns `false`. Any `false`
 returned via `add_metadata()` can probably be passed along as is.
 Thoughts?
 * We aren't testing cache in any way yet. We'll want to add some tests
 that run when object cache is available.
 * There's a repeating `@todo use clean_blog_cache here`. Does that need to
 be addressed?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37923#comment:75>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform