[wp-trac] [WordPress Trac] #40462: Add placeholders to wp_login_form()

WordPress Trac noreply at wordpress.org
Tue Feb 27 20:33:27 UTC 2018


#40462: Add placeholders to wp_login_form()
------------------------------------+--------------------------------------
 Reporter:  ramiy                   |       Owner:  voldemortensen
     Type:  enhancement             |      Status:  reopened
 Priority:  normal                  |   Milestone:
Component:  Login and Registration  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch 2nd-opinion   |     Focuses:  accessibility, template
------------------------------------+--------------------------------------
Changes (by s3w47m88):

 * keywords:  has-patch => has-patch 2nd-opinion
 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 @afercia you stated that you've not heard a actual use case that doesn't
 suggest one would remove or repeat the value of the Label. Particularly
 for the username and password fields. So here's a few:

 Some WordPress websites allow the email address as the username, while
 others do not use the email address as the username. WordPress MultiSite
 doesn't allow email addresses without modification. The Placeholder value
 can show that so the user knows what to enter. On some sites my staff and
 I build we write out the email in the placeholder, other times we put
 "John Doe", other times we say "Username Here", etc... In other words,
 developers could put whatever they want and no one knows what will go
 there except the developer.

 As for a password, having the * as the placeholder or descriptive text is
 a UI / UX choice made by the developer. I choose to use * in the password
 field for aesthetics even though it's not overtly helpful. Sometimes I put
 "12 Character Password Here" or "Password is Found In Your Email" because
 - like @richardkentgates mentioned I deal with surprisingly computer inept
 people.

 What's important to acknowledge and respect here is that no one know what
 a developer is going to put in those values and to believe we do is an
 assumption and that is solely based on opinion - instead of confirmed
 facts.

 The facts are that HTML supports placeholders for these fields, and the
 wp_login_form function exists to allow developers to customize the
 attributes that area associated with those fields. So, unless you or
 someone else can provide opinionated evidence that is based on verifiable
 facts about how accepting this patch is inconsistent with any programming
 standards it should be promptly accepted.

 Most importantly, no one here has the authority to dictate whether or not
 placeholders are used, how they're used, or why their used. That is out of
 scope of this submitted patch and should not be discussed here.

 And almost as important as that: there is a desire for this functionality
 by WordPress developers and it has literally NO consequence to anyone who
 opposes it. There has been NO evidence to support that this has any
 negative impact unless you're making an assumption about developer intent.


 Can anyone tell me who, exactly, has the authority to approve to deny or
 accept this patch?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40462#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list