[wp-trac] [WordPress Trac] #43101: Test to ensure MediaElement SWFs aren't accidentally added to build
WordPress Trac
noreply at wordpress.org
Tue Feb 27 14:40:35 UTC 2018
#43101: Test to ensure MediaElement SWFs aren't accidentally added to build
--------------------------------+---------------------
Reporter: iandunn | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.0
Component: External Libraries | Version: 4.9.2
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses:
--------------------------------+---------------------
Changes (by iandunn):
* status: new => closed
* resolution: => fixed
Comment:
Fixed in r42762, but I forgot the `#`...
> External Libraries: Test that MediaElement SWF files remain deleted.
>
> The files were removed from Core in r42462 because they're no longer
necessary, and have a history of security issues. They remain upstream,
though, so this test makes it explicitly clear that they should not be
added back in the future without careful consideration and discussion with
the Security team.
>
>
`Tests_Admin_IncludesUpdateCore::test_new_files_are_not_in_old_files_array_compiled()`
would already catch files with the exact same name, but this test will
also catch files with new names, just to be extra cautious.
>
> Props iandunn, ocean90, SergeyBiryukov
> Fixes 43101
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43101#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list