[wp-trac] [WordPress Trac] #43415: Remove "aria-required" attribute when "required" attribute is already used
WordPress Trac
noreply at wordpress.org
Mon Feb 26 08:00:33 UTC 2018
#43415: Remove "aria-required" attribute when "required" attribute is already used
-------------------------------------------------+-------------------------
Reporter: audrasjb | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future
Component: General | Release
Severity: normal | Version: 4.9.4
Keywords: good-first-bug has-patch needs- | Resolution:
refresh | Focuses:
| accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):
* keywords: good-first-bug has-patch => good-first-bug has-patch needs-
refresh
Comment:
@Shital Patel thanks for the patch. A good best practice for patches is to
try to not introduce unrelated changes, see onclick and readonly in
[attachment:43415.patch] better to not change them. Also, `required` is a
boolean attribute that means it doesn't need to have a specified value
`required="required"` and the correct syntax is just `required`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43415#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list