[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions

WordPress Trac noreply at wordpress.org
Mon Feb 26 00:09:43 UTC 2018


#41191: Create browse happy type notice for PHP versions
--------------------------------------------------+-----------------------
 Reporter:  joostdevalk                           |       Owner:  flixos90
     Type:  enhancement                           |      Status:  assigned
 Priority:  normal                                |   Milestone:  5.0
Component:  General                               |     Version:
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-opinion  |     Focuses:
--------------------------------------------------+-----------------------

Comment (by flixos90):

 As of last Thursday, the Serve Happy API is live on wordpress.org! See
 https://api.wordpress.org/core/serve-happy/1.0/?php_version=7.0 and
 https://meta.trac.wordpress.org/ticket/3474

 [attachment:41191.4.diff] is an updated patch for the dashboard widget
 (which is the approach we'll be going for, per last week's PHP meeting),
 calling the new .org API to determine the status of the PHP version. It
 furthermore introduces a filter to allow tweaking the direct PHP update
 URL (which is optional, and an addition to the information page URL). This
 allows hosts to link to their own specific upgrade instructions.

 With the API and the above patch in place, the core notice is almost ready
 to be merged. Remaining discussions:
 * The API on wordpress.org supports an `ip_address` parameter which has to
 be a truncated IP address where the last segment is always 0 (for privacy
 reasons, example: 123.456.789.0). This can be used in the future to
 possibly automatically detect the host and thus return a proper
 `update_url` (which at this point is a supported return value already, but
 always an empty string). It would be easy to make core future-proof in
 that regard: The actual notice already takes that return value into
 account, now we only have to decide whether we should actually send the
 (truncated) IP address or not.
 * Should the color of the notice remain red (typically for errors) or be
 changed to orange (typically for warnings)?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list