[wp-trac] [WordPress Trac] #43412: Comments: row action links and forms accessibility improvements

[WordPress Trac]

#43412: Comments: row action links and forms accessibility improvements
---------------------------------------+-----------------------------
 Reporter:  afercia                    |      Owner:
     Type:  defect (bug)               |     Status:  new
 Priority:  normal                     |  Milestone:  Awaiting Review
Component:  Comments                   |    Version:
 Severity:  normal                     |   Keywords:
  Focuses:  accessibility, javascript  |
---------------------------------------+-----------------------------
 In the Comments screen, all the "row action" links behave differently
 depending if JavaScript support is on or off. The Reply and Quick Edit
 links are special cases, and #43376 is going to take care of them.

 For all the other row action links except "Edit":
 - when JavaScript is off, they behave like real links
 - when JavaScript is on, they don't trigger navigation but they "do
 something" so for better semantics and accessibility they should have a
 `role="button"`.

 Basically, all the following links:
 {{{
 Approve / Unapprove | Spam | Trash
 Not Spam | Delete Permanently
 Spam | Restore | Delete Permanently
 }}}

 should use the CSS class `.aria-button-if-js` so the related jQuery
 function in `common.js` adds the button role.

 Additionally, in the Reply and Quick Edit forms the links "Cancel" and
 "Submit" (actually this link has different text depending on what it does)
 should be real buttons.

 Lastly, in the edit post screen, in the Comments metabox, the "Add
 Comment" link should be a button:

 [[Image(https://cldup.com/Cx48FB3L0r.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43412>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform