[wp-trac] [WordPress Trac] #43405: CS: Fix violations for wp-signup.php

[WordPress Trac]

#43405: CS: Fix violations for wp-signup.php
--------------------------+-------------------------------
 Reporter:  GaryJ         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  coding-standards
--------------------------+-------------------------------
Changes (by jrf):

 * version:   => trunk


Comment:

 +1

 Couple of small remarks/questions (line nrs refer to the "new" lines):
 - Line 122: `( $site_domain )` does not need the parentheses anymore as it
 is, though it might need output escaping.
 - Line 406/412 - the "Don't override WP globals" sniff is more than
 anything intended for plugins/themes. Should that sniff be excluded for
 core ?
 - Line 933: you may want to split this line up as it's pretty long now,
 i.e. one condition per line.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43405#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform