[wp-trac] [WordPress Trac] #41143: Theme/plugin editing: if you don't select a function it just returns without message

WordPress Trac noreply at wordpress.org
Tue Feb 20 22:12:23 UTC 2018


#41143: Theme/plugin editing: if you don't select a function it just returns
without message
--------------------------+------------------------
 Reporter:  karmatosed    |       Owner:  xkon
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  5.0
Component:  Themes        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------

Comment (by westonruter):

 Instead of a method name of `docsLookup` I think it would be better to
 have something more descriptive and “verby” like
 `updateDocsLookUpButtonDisabledState`. I'm not sure even a separate method
 is needed there, actually. The toggling of the `disabled` prop could be
 done right in the `change` handler.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41143#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list