[wp-trac] [WordPress Trac] #43274: Changing $(comments|feed)_base of WP_Rewrite causes errors because of hardcoded strings in redirect_canonical()

[WordPress Trac]

#43274: Changing $(comments|feed)_base of WP_Rewrite causes errors because of
hardcoded strings in redirect_canonical()
------------------------------------------------------+------------------
 Reporter:  dimadin                                   |       Owner:
     Type:  defect (bug)                              |      Status:  new
 Priority:  normal                                    |   Milestone:  5.0
Component:  Canonical                                 |     Version:
 Severity:  normal                                    |  Resolution:
 Keywords:  has-patch needs-refresh needs-unit-tests  |     Focuses:
------------------------------------------------------+------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch => has-patch needs-refresh needs-unit-tests


Comment:

 @dimadin

 Are you able to wrap the variables in regular expressions with
 `preg_quote()` to ensure they're escaped correctly?

 Some tests to ensure the function behaves as expected with custom bases
 would be great to see too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43274#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform