[wp-trac] [WordPress Trac] #40678: Editing menus in WP admin for blind people

[WordPress Trac]

#40678: Editing menus in WP admin for blind people
--------------------------+----------------------------
 Reporter:  juliemoynat   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0
Component:  Menus         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  accessibility
--------------------------+----------------------------

Comment (by audrasjb):

 Thanks @juliemoynat !

 > * '''add a title before each block:''' I thought more of adding a "h2"
 tag (instead of a "span") because people can navigate through titles with
 their screen readers. I know that sighted persons who use screen readers
 don't like to have hidden titles but that can be a real help for blind
 persons, in my opinion.
 Fixed in `40678.7.diff`
 > * '''add a screen reader text to “Add to menu” button:''' good job. You
 find the right words ;-)
 Great ;)
 > * '''add a screen reader text to links in the right column (just like in
 the left one):''' the text added is not at the right place (in the diff,
 it is in a "div" that can not receive focus). For this text being
 readable, we should add it in the link that have "item-edit" class. But...
 now, I see that this link has an aria-label attribute. (For information,
 an "aria-label" text overrides the content inside tags in a screen
 reader.) This attribute is suddenly modified with JavaScript... So this is
 more a bug to fix in JS.
 This one is quite tricky to implement. I'm still working on it.
 > * '''add a screen reader text after the 2 first tabs:''' I'm looking for
 the "add-edit-menu-action" class in my browser web developer tool to see
 where the text is added but I can't find it. Is the text adding to the
 right place? I think this text could be placed just before the "div
 .manage-menus" element in a "p" tag (because it's a paragraph ;-) ).
 Fixed in `40678.7.diff`

 @afercia Theorical question: what is the process for partial fixes? Is it
 okay to commit some fixes but let the ticket open?

 Cheers,
 Jb

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40678#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform