[wp-trac] [WordPress Trac] #39667: Improve showing metadata in media view

[WordPress Trac]

#39667: Improve showing metadata in media view
-------------------------------------------------+-------------------------
 Reporter:  Presskopp                            |       Owner:
     Type:  enhancement                          |  adamsilverstein
 Priority:  normal                               |      Status:  assigned
Component:  Media                                |   Milestone:  5.0
 Severity:  normal                               |     Version:
 Keywords:  has-screenshots has-patch has-unit-  |  Resolution:
  tests                                          |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch dev-feedback has-unit-tests => has-
     screenshots has-patch has-unit-tests


Comment:

 [attachment:39667.4.diff] is a refreshed patch with a few changes:

 Ideally, `aria-label` should be used on [https://www.w3.org/TR/html5/sec-
 forms.html#labelable-element labelable elements]. When used on other
 elements (previous patches used it on a span element), assistive
 technologies expect that element to have a native "role" (or an ARIA
 role). Since no ARIA role was set in the markup (and there's no applicable
 role), assistive technologies may announce something unexpected;
 VoiceOver, for example, fallbacks to a generic "group" role and announced
 the span element as "group". To avoid this, I've opted to use some screen-
 reader-text instead of an aria-label.

 [[Image(https://cldup.com/P8-Sq1n6Bv.png)]]

 I've applied the same enhancements to the attachment details in the "Add
 Media" modal.

 Note: the patch removes some unrelated trailing spaces (my editor does
 that automatically).

 Looks good to me, @adamsilverstein please do feel free to review and
 commit when you have a chance :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39667#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform